[#344] Update StoryFactory address and deployment block after redeploy#345
Merged
realproject7 merged 1 commit intomainfrom Mar 19, 2026
Merged
[#344] Update StoryFactory address and deployment block after redeploy#345realproject7 merged 1 commit intomainfrom
realproject7 merged 1 commit intomainfrom
Conversation
Replace old broken address 0x66087c... with new 0xc278F4... and update deployment block from 43559145 to 43561137 after creation-fee fix redeploy (plotlink-contracts#25). Fixes #344 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
approved these changes
Mar 19, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
T2b APPROVE
Clean constant updates across all three files after redeployment:
.env.example: mainnet comment updated ✓lib/contracts/constants.ts: STORY_FACTORY mainnet →0xc278F4...✓packages/sdk/src/constants.ts: STORY_FACTORY_MAINNET_ADDRESS →0xc278F4..., DEPLOYMENT_BLOCK_MAINNET → 43,561,137 ✓- CI green
LGTM.
project7-interns
approved these changes
Mar 19, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR cleanly updates the stale mainnet StoryFactory address and deployment block after the redeploy from plotlink-contracts#25. I did not find any remaining runtime references to the old address or old mainnet deployment block.
Findings
- [info] Repo-wide search found no remaining references to old mainnet address
0x66087c...or deployment block43559145after this change.
Decision
Approve because the constants are now aligned with the replacement mainnet deployment, and local npm run typecheck plus npm run build both pass.
4 tasks
realproject7
added a commit
that referenced
this pull request
Apr 3, 2026
Add reserve_usd_rate column to trade_history to store PLOT/USD at trade time. Both cron and webhook indexers now fetch and persist the rate. PriceChart gains a USD/PLOT toggle with dashed lines for approximate historical data. Includes tiered backfill script (exact via archive RPC, approximate fallback). Fixes #345 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
7 tasks
realproject7
added a commit
that referenced
this pull request
Apr 3, 2026
- Extract ONEINCH_SPOT_PRICE_AGGREGATOR to lib/contracts/constants.ts - Extract spotPriceAbi to lib/contracts/abi.ts - Add CHECK constraint on rate_source column - Document USDC 6-decimal assumption Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
realproject7
added a commit
that referenced
this pull request
Apr 3, 2026
…test - Backfill script now reads historical HUNT/USD per-block instead of using a single current PLOT/USD for all rows - Cron indexer marks trades as 'backfill_approx' during catch-up scans (>200 blocks behind head) instead of falsely labeling as 'live' - PriceChart labels last USD point as "last USD" (not "latest") when newer trades exist without USD data Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
realproject7
added a commit
that referenced
this pull request
Apr 3, 2026
… check Use fromBlock (oldest block in batch) instead of toBlock to determine catch-up status. Prevents the final catch-up batch from mislabeling older trades as 'live' when toBlock happens to be near head. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0x66087c...with0xc278F4099298118efA8dF30DF0F4876632571948in all constants43559145to43561137lib/contracts/constants.ts,packages/sdk/src/constants.ts,.env.exampleTest plan
npm run typecheckpassesnpm run buildpasses0x66087c...Fixes #344
🤖 Generated with Claude Code